Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set minimum supported Matrix 1.1 version (drop legacy r0 versions) #3007

Merged
merged 21 commits into from
Aug 14, 2023

Conversation

turt2live
Copy link
Member

@turt2live turt2live commented Dec 21, 2022

@andybalaam
Copy link
Contributor

@turt2live is this still ongoing?

@turt2live
Copy link
Member Author

Not by me, but is increasingly critical work the team will need to pick up.

@andybalaam
Copy link
Contributor

All the Prerequisites are merged, and the code looks fine to me.

The description says WIP - is there more to do @turt2live ?

@turt2live
Copy link
Member Author

I don't recall, sorry. This will need investigation from the team.

@andybalaam
Copy link
Contributor

I don't recall, sorry. This will need investigation from the team.

No problem. I don't see value in leaving this open in draft form since we are not currently working on it. The code will be valuable when we get to it, thank you.

@andybalaam andybalaam closed this Jul 20, 2023
@t3chguy t3chguy reopened this Jul 28, 2023
@t3chguy t3chguy changed the title Support Matrix 1.1 (drop legacy r0 versions) Set minimum supported Matrix 1.1 version (drop legacy r0 versions) Aug 8, 2023
@t3chguy t3chguy marked this pull request as ready for review August 8, 2023 08:34
@t3chguy t3chguy requested a review from a team as a code owner August 8, 2023 08:34
@t3chguy t3chguy self-assigned this Aug 8, 2023
@turt2live
Copy link
Member Author

this PR should also probably update the README text to say there's now a minimum version

Copy link
Member

@t3chguy t3chguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clearing my own review as I have taken over

Copy link
Contributor

@germain-gg germain-gg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

src/http-api/prefix.ts Outdated Show resolved Hide resolved
Co-authored-by: Germain <germains@element.io>
@t3chguy t3chguy added this pull request to the merge queue Aug 14, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 14, 2023
@t3chguy t3chguy merged commit 8c16d69 into develop Aug 14, 2023
20 checks passed
@t3chguy t3chguy deleted the travis/mx-v1.1/api branch August 14, 2023 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Prepare for Matrix v1.1
4 participants